Skip to content

fix: 汉化阿里安特玛兹拉美发对话#704

Open
skykiseki wants to merge 1 commit into
BeiDouMS:masterfrom
skykiseki:fix/mazra-ariant-hair-salon-zh-cn
Open

fix: 汉化阿里安特玛兹拉美发对话#704
skykiseki wants to merge 1 commit into
BeiDouMS:masterfrom
skykiseki:fix/mazra-ariant-hair-salon-zh-cn

Conversation

@skykiseki

Copy link
Copy Markdown
Contributor

变更内容

  • 汉化阿里安特美发店 NPC 玛兹拉的对话文本。
  • 补全美发券、染发券流程中的选择提示、成功提示和券不足提示。
  • 清理该脚本中残留的英文对话,避免中文环境下显示英文文本。

客户端影响

  • 本次只修改服务端 NPC 脚本,不依赖客户端 WZ 改动。

测试

  • 已确认修改范围仅包含玛兹拉对应 NPC 脚本。
  • 已在中文脚本中检查无乱码和残留英文提示。

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

🤖 AI Code Review

The user wants me to review a pull request for a MapleStory v83 server project. Let me analyze the diff carefully.

The changes are in gms-server/scripts-zh-CN/npc/2100006.js, which is the NPC script for "Mazra" - a Hair Salon Owner in The Burning Road: Ariant map.

Looking at the diff:

  1. Header comment block: Replaced tab indentation with spaces (4 spaces)
  2. Status 0 dialogue: Changed NPC greeting text - replaced curly quotes with regular quotes, removed curly apostrophes, adjusted Chinese phrasing
  3. Status 1 (haircut selection): Translated the English text to Chinese
  4. Status 1 (dye selection): Translated the English text to Chinese
  5. Status 2 (haircut success/failure): Refined Chinese text
  6. Status 2 (dye success/failure): Refined Chinese text

This is essentially a Chinese localization/translation improvement PR. Let me assess:

Potential Issues:

  • The change from "阿里安特发型券(VIP)" to "阿里安特美发券(VIP)" is a terminology change. Consistency between the initial NPC greeting and the subsequent options (5150027) should be checked. The initial greeting says "美发券" (hair beauty coupon) but the item name in the L0 option is "阿里安特发型券" → wait, looking at the L0/L1 options: #i5150027##t5150027# - this references the actual item name, which I assume is defined elsewhere as "阿里安特发型券(VIP)". So the initial message says "美发券" but the item name might be "发型券" - this could be an inconsistency.

Wait, let me look again. The #t5150027# will display the item name from the inventory data. So the L0 line shows whatever the item is called. The greeting message says "美发券" but if the item is actually called "发型券", there's a terminology mismatch between the NPC's introduction and the actual item name.

Actually, looking at the success message: "需要美发券我才能为你的头发施展魔法" - this also uses "美发券". And the failure message uses "染发券" for the dye.

The terminology change from "发型券" to "美发券" might or might not match the actual item name. This is a potential inconsistency issue.

  • The header comment change from tabs to spaces is a minor formatting change but might not match the project style. However, it doesn't affect functionality.
  • The function pushIfItemExists is being called but I don't see it defined in this file. It must be in a shared utility. Not changed in this PR though.

Translation Quality:

  • The translations look natural and improved compared to the previous machine-translated version
  • "哈哈哈……" (with ellipsis character) is more natural than the previous "哈哈哈..."
  • The colloquial tone is appropriate for an NPC

Functionality:

  • No functional changes - just text content
  • Game logic is unchanged

Let me structure the review:

📋 PR 概览: 改进了 NPC Mazra(美发沙龙老板)的对话中文翻译,从直译/机翻改为更自然的口语化表达。

⚠️ 潜在问题:

  • 🟡 中危: 术语不一致 - 欢迎语中将"阿里安特发型券"改为"阿里安特美发券",但 L0 选项中的 #t5150027# 会显示实际的物品名(如果物品名是"发型券"而非"美发券"),会造成术语前后不一致
  • 🟢 低危: 头注释从 Tab 缩进改为 4 空格,与项目其他文件风格可能不一致(不过这是改进的格式)
  • 🟢 低危: status 0 欢迎语去掉了中文引号"……",与其他保持"我应该说过了,需要美发券我才能..."的句式相比统一性需要确认

💡 改进建议:

  1. 核实物品 5150027 的实际名称,确保"美发券"与物品名保持一致
  2. 考虑统一全部使用中文省略号"……"或英文省略号"..."
  3. 可以在头部注释中标注这是中文化润色版本,便于维护

📊 评分:

  • 代码质量: 4/5 (无功能性变化,纯文本优化)
  • 安全性: 5/5 (无安全影响)
  • 可维护性: 4/5 (翻译更自然,但需注意术语一致性)

Let me write a clean, structured Chinese review.

📋 PR 概览

NPC 2100006.js(Mazra 阿里安特美发沙龙老板)的中文对话文案润色,从直译/机翻风格改为更自然的口语化中文,同时将头注释由 Tab 缩进改为 4 空格。无功能性逻辑改动。

⚠️ 潜在问题

  • 🟡 中危 — 道具名术语前后不一致
    欢迎语将 #b阿里安特发型券(VIP)#k 改为 #b阿里安特美发券(VIP)#k,但下方 #L0# 行的 #t5150027# 会输出 Item.wz 中该道具的真实名称。如果道具实际叫「阿里安特发型券(VIP)」,玩家会看到 NPC 介绍和菜单显示的名词不一致,容易产生困惑。建议先在 wz 中确认 5150027 / 5151022 的中文名,再决定用「发型券」还是「美发券」。

  • 🟢 低危 — 省略号风格不统一
    status 0 的对话里使用了中文省略号 ……,而 status 1 的「哈哈哈~」则保留了 ASCII 波浪号。同一 NPC 的语气助词符号应保持统一。

  • 🟢 低危 — 头注释缩进风格变更
    仅这一个文件从 Tab 改为 4 空格,会与 scripts-zh-CN/npc/ 下其他上百个文件风格不一致。批量改更好,或者保持原 Tab 风格(NPC 脚本对缩进不敏感,没必要单独动它)。

💡 改进建议

  1. 核对 Item.wz 中 5150027 / 5151022 的中文命名,把「美发券 / 染发券 / 发型券」三个名词在欢迎语、菜单、提示语三处统一,避免出现"我说的是 A,菜单给的是 B"的情况。
  2. 统一省略号和语气符号——全部使用 ……~,或全部使用 ...,让一个 NPC 的语气更连贯。
  3. 保留 pushIfItemExists 等公共函数在头注释中的说明(虽然本次未改),但建议在新版本头注释里加一行 // Localized by <作者> @ <日期>,方便后续维护追溯。

📊 评分

维度 分数 说明
代码质量 4/5 纯文案润色,无逻辑改动
安全性 5/5 NPC 脚本不涉及权限与数据流
可维护性 3/5 术语一致性问题若不修,后续翻译审校成本会累积

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant