m4: fix local ffmpeg and avcodec function conflict #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
This is valid during static linking only |
Autotools miss avcodec function check. This is due to linker library list order, -ldrm is appended too early respect to -lavutil. This results in missing drm library functions for avcodec functions: - drmGetVersion() - drmFreeVersion() So these functions: - avcodec_get_context_defaults3 - avcodec_open2 - avcodec_encode_video2 can't link correctly during check and they seem not to be present. Then macros HAVE_FUN_avcodec_* are not defined in mediastreamer-config.h So local avcodec functions conflict with real avcodec library functions. In acinclude.m4 file, swap $FFMPEG_LIBS and -lavutil if avcodec is found. Signed-off-by: Giulio Benetti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autotools miss avcodec function check.
This is due to linker library list order, -ldrm is appended too early
respect to -lavutil. This results in missing drm library functions for
avcodec functions:
So these functions:
can't link correctly during check and they seem not to be present.
Then macros HAVE_FUN_avcodec_* are not defined in mediastreamer-config.h
So local avcodec functions conflict with real avcodec library functions.
In acinclude.m4 file, swap $FFMPEG_LIBS and -lavutil if avcodec is found.
Signed-off-by: Giulio Benetti [email protected]