Use AV_INPUT_BUFFER_PADDING_SIZE to determine padding size #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hardcoding the value for FF_INPUT_BUFFER_PADDING_SIZE is not safe because upstream FFmpeg might change it (as they did in FFmpeg 4.0). Instead, use FFmpeg's AV_INPUT_BUFFER_PADDING_SIZE if available and only hardcode a value if FFmpeg is disabled (in which case the value doesn't particularly matter anyway). For compatibility with older FFmpeg versions, define AV_INPUT_BUFFER_PADDING_SIZE if hasn't been defined yet. Source: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=901735
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hardcoding the value for FF_INPUT_BUFFER_PADDING_SIZE is not safe because
upstream FFmpeg might change it (as they did in FFmpeg 4.0).
Instead, use FFmpeg's AV_INPUT_BUFFER_PADDING_SIZE if available and only
hardcode a value if FFmpeg is disabled (in which case the value doesn't
particularly matter anyway). For compatibility with older FFmpeg versions,
define AV_INPUT_BUFFER_PADDING_SIZE if hasn't been defined yet.
Source: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=901735