Fix WAV audio recordings #32
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using WAV as the audio recording format resulted in corrupted files where the chunk length did not propery correspond to the actual chunk content or file length. This was caused by initially writing the audio samples to the start of the file instead of the data chunk. On close, writing the WAV header would then overwrite the first bytes of audio.
schlagert
pushed a commit
to lindenbaum/mediastreamer2
that referenced
this pull request
Jul 12, 2022
|
@Mickhopes is there any chance of getting this merged? (assuming conflicts would be resolved) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using WAV as the audio recording format resulted in corrupted files where the chunk length did not properly correspond to the actual chunk content or file length.
This was caused by initially writing the audio samples to the start of the file instead of the data chunk. On close, writing the WAV header would then overwrite the first bytes of audio.