Conversation
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Lines 515 to 520 in 8ca7a03
[P0] Repetition cuckoo table remains sized for small boards
The VERY_LARGE_BOARDS path in types.h bumps SQUARE_NB to 256, so Position::init() now iterates over four times as many squares when filling the cuckoo repetition table. However the table allocation and hash masks in position.cpp are still guarded by #ifdef LARGEBOARDS only, leaving an 8192‑entry table and 13‑bit masks for a workload that previously required 65536 entries. With a 256‑square board the insertion loop never finds an empty slot and spins indefinitely (or corrupts memory) during module initialisation. The table sizing and expected count assertions should also include VERY_LARGE_BOARDS to avoid the startup crash.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| else: | ||
| args = ["-std=c++17", "-flto", "-Wno-date-time"] | ||
|
|
||
| args.extend(["-DLARGEBOARDS", "-DALLVARS", "-DPRECOMPUTED_MAGICS", "-DNNUE_EMBEDDING_OFF"]) | ||
| args.extend(["-DVERY_LARGE_BOARDS", "-DALLVARS", "-DNNUE_EMBEDDING_OFF"]) | ||
|
|
There was a problem hiding this comment.
[P1] Extend wide-board FEN parser to VERY_LARGE_BOARDS
Switching the Python extension to compile with -DVERY_LARGE_BOARDS (setup.py line 15) enables 12×12 Omega FENs that contain multi‑digit empty counts such as *10*. The parser in Position::set() only accepts two‑digit numbers when LARGEBOARDS is defined, so the new build falls back to the 8×8 logic and reads 10 as two separate digits. That leaves each rank two squares short and produces an invalid position before any move is played. The Omega start position added in this commit will therefore be misloaded. Please gate the two‑digit handling with || defined(VERY_LARGE_BOARDS) wherever FEN parsing depends on board width.
Useful? React with 👍 / 👎.
|
@codex fix comments |
|
Summary
Testing
|
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68cc5e69d3348322beb185dbec93be00