Add support for very large boards and guard Omega variant#14
Add support for very large boards and guard Omega variant#14Belzedar94 wants to merge 4 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Fairy-Stockfish/src/position.cpp
Lines 281 to 438 in fe598c9
[P0] Parse 12×12 FEN rows incorrectly in VERY_LARGE builds
The FEN parser still treats multi‑digit empty square counts and rank coordinates only when LARGEBOARDS is defined. In a VERY_LARGE_BOARDS build the code at Position::set never reads the second digit of tokens like 10, so the new 12×12 Omega start position is misinterpreted and sq advances by one square instead of ten. The same guard around the en‑passant loop reads only a single rank character. On startup the engine parses Omega’s FEN and writes past the board arrays, which is why the VERY_LARGE_BOARDS binary crashes immediately. These blocks should include VERY_LARGE_BOARDS so that two‑digit ranks/files are parsed correctly for 16×16 style boards.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68cc5e69d3348322beb185dbec93be00