Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new private property to ParsedownExtended for storing a list of internal hosts from configuration.
- Introduces
$internalHostsproperty with default empty array - Adds PHPDoc for the new property
Comments suppressed due to low confidence (2)
src/ParsedownExtended.php:60
- Consider specifying the element type in the PHPDoc (e.g.,
@var string[]) for better clarity and static analysis support.
/** @var array $internalHosts List of internal hosts loaded from configuration */
src/ParsedownExtended.php:61
- [nitpick] Add a unit test to verify that
$internalHostsis correctly populated from configuration and integrated into link processing behavior.
private array $internalHosts = [];
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new property to the
ParsedownExtendedclass to store a list of internal hosts loaded from configuration.Changes to
ParsedownExtendedclass:src/ParsedownExtended.php: Added a new private property$internalHoststo store a list of internal hosts loaded from configuration. This complements the existing$internalHostsSetproperty for link processing.