Skip to content

Fix for deprecated dynamic property#110

Merged
BenjaminHoegh merged 1 commit intomainfrom
BenjaminHoegh-patch-1
Jul 8, 2025
Merged

Fix for deprecated dynamic property#110
BenjaminHoegh merged 1 commit intomainfrom
BenjaminHoegh-patch-1

Conversation

@BenjaminHoegh
Copy link
Owner

This pull request introduces a new property to the ParsedownExtended class to store a list of internal hosts loaded from configuration.

Changes to ParsedownExtended class:

  • src/ParsedownExtended.php: Added a new private property $internalHosts to store a list of internal hosts loaded from configuration. This complements the existing $internalHostsSet property for link processing.

@BenjaminHoegh BenjaminHoegh marked this pull request as ready for review July 8, 2025 06:25
Copilot AI review requested due to automatic review settings July 8, 2025 06:25
@BenjaminHoegh BenjaminHoegh merged commit c21533b into main Jul 8, 2025
15 checks passed
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new private property to ParsedownExtended for storing a list of internal hosts from configuration.

  • Introduces $internalHosts property with default empty array
  • Adds PHPDoc for the new property
Comments suppressed due to low confidence (2)

src/ParsedownExtended.php:60

  • Consider specifying the element type in the PHPDoc (e.g., @var string[]) for better clarity and static analysis support.
    /** @var array $internalHosts List of internal hosts loaded from configuration */

src/ParsedownExtended.php:61

  • [nitpick] Add a unit test to verify that $internalHosts is correctly populated from configuration and integrated into link processing behavior.
    private array $internalHosts = [];

@BenjaminHoegh BenjaminHoegh deleted the BenjaminHoegh-patch-1 branch February 26, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants