fix: harden hook and signature resolution for optimized IL2CPP builds#262
Open
hazre wants to merge 1 commit into
Open
fix: harden hook and signature resolution for optimized IL2CPP builds#262hazre wants to merge 1 commit into
hazre wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to get Resonite's upcoming IL2CPP renderer builds (prerelease branch on steam) working, it kept crashing with errors like this:
I've looked around and it seems to be a commonly reported issue, that is supposedly been fixed? #119 #183 BepInEx/BepInEx#820 BepInEx/BepInEx#1109
After investigating it it seems like:
Fix: if it looks inlined, just use the parent function instead.
Fix: make the bounds check more stricter, so that the address actually lives inside the DLL before trusting it.
I've not tested this with other games, if there is a small list of games (ideally free or smth) I can test against to make sure it works everywhere and it doesn't break already working stuff, I can do that.