Several Improvements #146
Merged
Several Improvements #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a schema defines a `state` attribute or element, the generated code for the quick_xml deserializer has a naming conflict of the struct fields. To resolve this we renamed the internal state of the deserializer to `state__`.
The interpreter paniced if a schema defined a `xs:pattern` for enum or union types. To solve this we now apply constrains derived from the different facets for all suitable types (simple, enum and union).
Bergmann89
force-pushed
the
improvements
branch
from
69af426 to
3faff23
Compare
If a element is nillable and at the same time a substitution group the generated code was invalid. The dynamic type was created on the nillable type, not on the inner type of the nillable type.
Bergmann89
force-pushed
the
improvements
branch
from
3faff23 to
1efdd61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #137 and #140