Fix nameing conflicts for groups from different namespaces #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If groups with the same name, but from different namespaces were references in the same type, it causes a naming conflict. This commit adds the prefix of the namespace to the name of the elements generated for a group from a different namespace to fix this issue.
If a namespace does not have a valid prefix, we generated a `NS_DEFAULT` constant for this namespaces. If we have multiple namespaces without prefix, this causes a conflict. This commits renames the `NS_DEFAULT` to `NS_UNNAMED_X`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #150