Refactor course id into env var#145
Open
ShreyasKallingal wants to merge 3 commits intoBerkeley-CS61B:mainfrom
Open
Refactor course id into env var#145ShreyasKallingal wants to merge 3 commits intoBerkeley-CS61B:mainfrom
ShreyasKallingal wants to merge 3 commits intoBerkeley-CS61B:mainfrom
Conversation
|
@ShreyasKallingal is attempting to deploy a commit to the cs61b's Team Team on Vercel. A member of the Team first needs to authorize it. |
590261a to
1c9f006
Compare
Collaborator
|
Lets also add it here to require this at build time https://github.com/Berkeley-CS61B/simple-office-hours-queue/blob/main/src/env/schema.mjs |
Contributor
Author
|
Fixed! |
Collaborator
|
Also clientEnv should be and then we can change cosntants.ts to be just to stay consistent |
Contributor
Author
|
Ah got it, fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extremely significant contribution that allows courses to rebrand the queue. Let me know if you'd like to keep the 61B™️ branding somewhere though :)
Also, explicitly included the minimum node version in package-json.