Add basic support for multis in pipelines. by Bernie · Pull Request #1 · Bernie/redis-cluster-client

Bernie · 2025-12-03T21:37:54Z

Adds basic support for multis in pipeline.

Basic means basic. No watching, no cross node validation, no timeouts for blocking commands. . . BASIC!

results = redis_cluster.pipelined do |pipe|
  10.times.each do |i|
    pipe.multi do |multi|
      multi.call('INCR", "#{i}")
      multi.call('INCRBY', "#{i}", 2)
    end
  end
end

results should be:

[[1,3],[1,3],[1,3],[1,3],[1,3],[1,3],[1,3],[1,3],[1,3],[1,3]]

…ssing an out-of-range slot (redis-rb#466)

…hRing Ref: rails/rails#57004 Ref: redis-rb/redis-client#292 I'm working on a big cleanup of Rails `RedisCacheStore` and it needs to support consistent hashing, which I did add in `redis-client` `0.28.0`. For Rails users to be able to use a redis cluster as a cache store, `redis-cluster-client` would need to have a shim for the now base interface: - `with` - `nodes` - `node_for` - `nodes_for`

…HashRing` (redis-rb#470)

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

…uster-state change (redis-rb#476)

…edis-rb#477)

Fix typos (metdata, hashag, guaranted, transction, fhe, GItHub), grammar issues (missing verbs, wrong verb forms, uncountable nouns), and Japanese-English patterns (upper libraries, works multiple keys, recommend to use, the followings, etc.) across README.md and source comments. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…#481)

…mplementation - class_diagrams_redis_cluster_client.md: - RedisClient::Cluster: add multi() and with() - RedisClient::ClusterConfig: replace obsolete per_node_key/update_node/add_node/dup with client_config_for_node, resolved?, sentinel?, server_url, and timeout readers - RedisClient::Cluster::Command: add exists?() - RedisClient::Cluster::Node: remove non-existent self.load_info(), add try_reload!, clients, primary_clients, replica_clients - Add RedisClient::Cluster::Node::BaseTopology class - Add RedisClient::Cluster::Node::RandomReplicaOrPrimary class (was missing) - Remove module_RedisClient_Cluster_Node_ReplicaMixin (no longer exists) - Update topology class relationships to use inheritance from BaseTopology - RedisClient::Cluster::Router: remove non-existent try_send(), add all current public methods (handle_redirection, scan_single_key, find_node_key_by_key, etc.) - Add RedisClient::Cluster::OptimisticLocking class and its relationships - module_RedisClient_Cluster_NodeKey: add build_from_client() - class_diagrams_redis_client.md: - RedisClient: add self.ring, self.now, self.now_ms, server_url, db, host, port, path, username, password, idle_timeout, disable_reconnection, measure_round_trip_delay - module_RedisClient_Common: add nodes, node_for, nodes_for - module_RedisClient_Config_Common: add idle_timeout, protocol, circuit_breaker, custom, inherit_socket, driver_info, middlewares_stack, resolved?, server_url, build_lib_name - RedisClient::SentinelConfig: add resolved? - RedisClient::RubyConnection: add measure_round_trip_delay - sequence_diagrams.md: - Update initial topology fetch from CLUSTER NODES to CLUSTER SHARDS (with fallback note for older Redis versions) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…mplementation (redis-rb#482)

redis-rb#504)

Some managed Redis services (e.g. AWS ElastiCache Serverless) report `127.0.0.1` in the `ip` field of `CLUSTER SHARDS` while exposing the real, reachable address only via `endpoint` / `hostname`. Building node_keys from `ip` then yields an unreachable topology and the client fails on the next operation that walks all nodes (e.g. `SCAN`/`delete_matched`) with: Connection refused - connect(2) for 127.0.0.1:6379 This regressed in v0.16.0 (redis-rb#479) when topology discovery switched from `CLUSTER NODES` to `CLUSTER SHARDS`; redis-rb#207 had previously established hostname precedence for the `CLUSTER NODES` path. `parse_cluster_shards_reply` now picks the host using: 1. `endpoint` (server-selected per `cluster-preferred-endpoint-type`) 2. `hostname` (when `endpoint` is absent or `?`) 3. `ip` (fallback) mirroring the precedence used by `parse_node_key` for CLUSTER NODES. Refs: redis-rb#515

…s-rb#516)

…ti/exec.

…er a redirect.

supercaracal and others added 30 commits December 20, 2025 13:16

ci: remove minitest benchmark codes (redis-rb#454)

5fc36bb

ci: bump redis version (redis-rb#455)

ec3eed6

ci: fix flaky test cases since minitest 6 (redis-rb#456)

d6cbb75

ci: bump ruby version to 4 (redis-rb#458)

e639bba

chore: add irb to gemfile (redis-rb#460)

1aee646

test: add a case to concurrent-worker test (redis-rb#461)

1dcb2fc

fix: ractor-related error (redis-rb#462)

0c7cb1c

build: release 0.13.7 (redis-rb#463)

4387eab

feat: add multiple db support (redis-rb#464)

19e0ad3

build: release 0.14.0 (redis-rb#465)

5057c4d

fix: cluster countkeysinslot call throws an unintentional error if pa…

57e4eb5

…ssing an out-of-range slot (redis-rb#466)

build: release 0.14.1 (redis-rb#467)

b8382d4

style: appease liner (redis-rb#468)

5f20025

test: fix lint errors (redis-rb#469)

470a544

Add compatibility layers for RedisClient::Pooled and `RedisClient::…

5a02893

…HashRing` (redis-rb#470)

build: release 0.15.0 (redis-rb#471)

f8558d3

ci: workflow does not contain permissions (redis-rb#472)

fa116b2

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

fix: a TOCTOU race condition (redis-rb#473)

27d7413

perf: improve hashtag extraction (redis-rb#474)

d568ed6

perf: reduce hash lookup (redis-rb#475)

949ba4c

fix: reduce wasted retries and mitigate thundering-herd problem on cl…

9b9c82f

…uster-state change (redis-rb#476)

test: increase max-attempt count in test_against_cluster_broken.rb (r…

624d4b2

…edis-rb#477)

fix: revert reduction of retrying (redis-rb#478)

b5d6a53

fix: use CLUSTER SHARDS instead of CLUSTER NODES (redis-rb#479)

becd224

docs: fix readme (redis-rb#480)

3247d8e

docs: fix English grammar, spelling, and unnatural phrasing (redis-rb…

c6935fd

…#481)

docs: update class diagrams and sequence diagram to reflect current i…

2c42b20

…mplementation (redis-rb#482)

supercaracal and others added 18 commits May 4, 2026 10:24

chore: refactor benchmark scripts (redis-rb#502)

31eefcf

chore: rename a module for bench (redis-rb#503)

0a2a53a

fix: pin a node during a pipeline or scan even if random-scale reading (

75191f9

redis-rb#504)

chore: fix an envoy setting for bench (redis-rb#505)

084ad7a

perf: reduce hash references as possible (redis-rb#506)

333ef33

perf: optimize memory allocations for single thread task (redis-rb#507)

22bed76

test: get rid of wasting sleep (redis-rb#508)

ca0b647

chore: fix ips bench (redis-rb#509)

c704604

chore: refactor bench scripts (redis-rb#510)

f374549

build: release 0.16.3 (redis-rb#511)

226bb49

chore: refactor some trivial code (redis-rb#512)

564189b

chore: use hiredis-client for bench (redis-rb#513)

169d9c5

chore: fix bench scripts for async redis ruby (redis-rb#514)

9bff8df

fix: prefer endpoint over ip in CLUSTER SHARDS topology parsing (redi…

c9d316d

…s-rb#516)

build: release 0.16.4 (redis-rb#517)

e0de1d5

chore: add keys-lot conversion to bench (redis-rb#518)

61613a0

Add basic support for multis in pipelines.

bdeb1e1

Bernie force-pushed the pipelined_multis branch from 1f6c43e to bdeb1e1 Compare May 15, 2026 13:29

Bernie added 9 commits May 15, 2026 10:22

Fix consistency error checking.

90b2282

Propagate errors when found in the multi exec.

90ad931

Make exec metadata a set of indices.

f0d231e

Refined the test assertion.

9398212

Fix redirection to exclude redirecting commands that are within a mul…

55fb7f7

…ti/exec.

Fix size reference.

68e7bc6

Fix pipelined multi when exception is false.

d83cf5b

Implement testing for pipelined transaction redirect.

76ad778

Implement redirect of pipelined transactions on ASK/MOVE.

80af0ea

Bernie force-pushed the pipelined_multis branch from 1ebeb38 to 80af0ea Compare May 19, 2026 18:43

Ensure errors are still raised when occurring inside a MULTI/EXEC aft…

5976105

…er a redirect.

Navigation Menu

Add basic support for multis in pipelines. - #1

Add basic support for multis in pipelines.#1
Bernie wants to merge 83 commits into
masterfrom
pipelined_multis

Bernie commented Dec 3, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Bernie commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Bernie commented Dec 3, 2025 •

edited

Loading