refactor: code cleanup#326
Merged
Merged
Conversation
Berny23
reviewed
May 26, 2026
Berny23
reviewed
May 26, 2026
Owner
|
Thanks, looks good! Please check my two review comments. |
Contributor
Author
|
I noticed a few bugs, I will convert this to a draft for now. |
Open
Glitxhhh
pushed a commit
to Glitxhhh/LD-ToyPad-Emulator
that referenced
this pull request
May 30, 2026
Brings in 20 upstream commits: JS code quality refactoring (var->let/const, for-of loops, find vs filter, childNode.remove(), Number.parseInt, Set for world blacklist, move functions to global scope) and two bug fixes (remove deleted tokens from JSON, remove invalid assignment). Conflict resolutions: - server/stylesheets/main.css: kept fork CSS variable theming system (dark/light theme with CSS custom properties) — upstream "remove duplicate CSS" commit is not applicable to the rewritten stylesheet - server/index.html: combined upstream lang="en" with fork data-theme="dark" on the <html> tag to get both accessibility and default dark theme - server/scripts/main.js: took upstream global-scope function layout, then restored fork improvements to createItemHtml (has-image class, token-name span, flex image styling) and applyNameFilter (.token-name targeting fix) Post-merge fix: - index.js: reverted node: require prefix (node:fs/path/http -> fs/path/http) added by upstream commit 2f76c6d — requires Node 14.18+, breaks npm setup which targets Node 11 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.