fix(models): avoid AttributeError on LiteLLM_ProxyModelTable revalidation - #37808
Open
wuying8 wants to merge 1 commit into
Open
Conversation
Contributor
Greptile SummaryThe PR prevents
Confidence Score: 5/5The PR appears safe to merge, with no actionable regressions identified. The validator now safely preserves non-dictionary inputs while retaining the existing parsing behavior for dictionary construction paths, and the regression test covers the reported model-instance revalidation case.
|
| Filename | Overview |
|---|---|
| litellm/models/model.py | Adds a narrow input-shape guard while preserving JSON-string normalization for dictionary inputs. |
| tests/test_litellm/models/test_models.py | Adds focused regression coverage confirming that an existing proxy model instance can be revalidated without losing field values. |
Reviews (1): Last reviewed commit: "fix(models): avoid AttributeError on Lit..." | Re-trigger Greptile
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
wuying8
force-pushed
the
litellm_fix_model_block_response_serialization
branch
from
August 21, 2026 09:50
efcfcca to
f343c3f
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Problem this solves:
How it solves it:
Relevant issues
Linear ticket
Pre-Submission checklist
Proof of Fix
Before fix:
POST /model/block -> HTTP 500 (AttributeError: 'LiteLLM_ProxyModelTable' object has no attribute 'get')
After fix:
POST /model/block -> HTTP 200 OK with model details payload
Type
🐛 Bug Fix
Changes
litellm/models/model.py: Type-guardvaluesincheck_potential_json_strvalidator to handleLiteLLM_ProxyModelTableinstances during response revalidation.tests/test_litellm/models/test_models.py: Add regression test formodel_validateon an existingLiteLLM_ProxyModelTableinstance.Final Attestation