Skip to content

Fix dex config secret reading from env#10

Merged
BetterAndBetterII merged 1 commit intomainfrom
cursor/fix-dex-config-secret-reading-from-env-40cb
Aug 18, 2025
Merged

Fix dex config secret reading from env#10
BetterAndBetterII merged 1 commit intomainfrom
cursor/fix-dex-config-secret-reading-from-env-40cb

Conversation

@BetterAndBetterII
Copy link
Owner

Update Dex configuration to read the OIDC client secret from an environment variable to allow for custom secrets.


Open in Cursor Open in Web

Co-authored-by: 123090848 <123090848@link.cuhk.edu.cn>
@cursor
Copy link

cursor bot commented Aug 18, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @BetterAndBetterII, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Dex configuration to retrieve the OIDC client secret from an environment variable instead of using a hardcoded value. This enhancement allows for greater flexibility and security by enabling the use of custom and dynamically managed secrets for OIDC client authentication.

Highlights

  • Dex Configuration Update: Modified config/dex.config.yaml to read the OIDC client secret from the OIDC_CLIENT_SECRET environment variable.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the Dex configuration to read the OIDC client secret from an environment variable, which is a good security practice. I've added one comment regarding a potential configuration conflict where the client is marked as public, which may cause the newly configured secret to be ignored by Dex.

@BetterAndBetterII BetterAndBetterII marked this pull request as ready for review August 18, 2025 19:05
@BetterAndBetterII BetterAndBetterII merged commit c569365 into main Aug 18, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants