Skip to content

Conversation

@jasonjgardner
Copy link
Collaborator

This PR adds a new Advanced menu item which updates options.txt to re-enable RTX in worlds.

@jasonjgardner jasonjgardner self-assigned this Jun 1, 2025
@jasonjgardner jasonjgardner added the enhancement New feature or request label Jun 1, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new Advanced menu item that updates the game’s options.txt to enable advanced video settings for RTX performance.

  • Introduce Update-OptionsFile to toggle or add show_advanced_video_settings:1 in options.txt
  • Add Enable-GfxOptions function and wire it to a new “Fix GFX Options” menu item
  • Define corresponding translation strings and enable the new menu item based on selection
Comments suppressed due to low confidence (1)

v2/installer.ps1:1234

  • This attaches a click handler to the entire Advanced menu and calls Update-OptionsFile without supplying the required -OptionsFile parameter. It should be removed, as the new menu item already has its own click handler.
$advancedMenu.Add_Click({ Update-OptionsFile })

@jasonjgardner jasonjgardner requested a review from ABUCKY0 June 1, 2025 18:29

function Enable-GfxOptions() {
$comMojang = [System.Environment]::GetFolderPath("LocalApplicationData") + "\Packages\Microsoft.MinecraftUWP_8wekyb3d8bbwe\LocalState\games\com.mojang"
$previewComMojang = [System.Environment]::GetFolderPath("LocalApplicationData") + "\Packages\Microsoft.MinecraftPreview_8wekyb3d8bbwe\LocalState\games\com.mojang"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way we could get the path without hardcoding it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants