Merge pull request #2612 from BetterThanTomorrow/2606-connect-sequenc…

…es-preferences-priority

Sort connect sequence configuration sources User last

* Fixes #2606

CHANGELOG.md

@@ -5,6 +5,7 @@ Changes to Calva.
 ## [Unreleased]
 
 - Bump deps.clj to v1.11.3.1463
+- [Prioritize Workspace configured connect sequences over User configured dittos](https://github.com/BetterThanTomorrow/calva/issues/2606)
 
 ## [2.0.467] - 2024-07-14
 

docs/site/connect-sequences.md

@@ -47,6 +47,13 @@ A connect sequence configures the following:
 
 The [Calva built-in sequences](https://github.com/BetterThanTomorrow/calva/blob/published/src/nrepl/connectSequence.ts) also use this format, check them out to get a clearer picture of how these settings work.
 
+!!! Note "How sequence configurations are merged"
+    The sequence configuration, `calva.replConnectSequences` is an array and the sequences in the array will be listed and processed in the order they appear. However, you can configure connect sequences in several places, even if they make most sense on the Workspace level. The configurations are merged in the following order:
+
+    1. Workspace Folder settings
+    1. Workspace settings
+    1. User settings
+
 !!! Note "Force the project type menu to show"
     The convenience of `autoSelectForJackIn/Connect` can be an inconvenience when you want to use another project type/sequence for a project. For this reason, the `calva.connect` and `calva.jackIn` can be provided with an option `disableAutoSelect`, which forces the project root and project type menus to show. See [Options for the Connect Command](connect.md#options-for-the-jack-in-command) and [Options for the Jack-in Command](connect.md#options-for-the-connect-command) for more on this.
 

src/config.ts

@@ -183,9 +183,9 @@ function getConfig() {
   const replConnectSequencesConfig =
     configOptions.inspect<ReplConnectSequence[]>('replConnectSequences');
   const replConnectSequences = [
-    ...(replConnectSequencesConfig.globalValue ?? []),
-    ...(replConnectSequencesConfig.workspaceValue ?? []),
     ...(replConnectSequencesConfig.workspaceFolderValue ?? []),
+    ...(replConnectSequencesConfig.workspaceValue ?? []),
+    ...(replConnectSequencesConfig.globalValue ?? []),
   ].map((sequence) => {
     if (Array.isArray(sequence.afterCLJReplJackInCode)) {
       return {

test-data/.vscode/settings.json

@@ -75,6 +75,7 @@
       "projectType": "deps.edn",
       "projectRootPath": ["projects/pirate-lang"],
       "afterCLJReplJackInCode": ["(require 'repl)", "(println 1)", "(println 2)"],
+      // "autoSelectForJackIn": true,
       "cljsType": "none",
       "menuSelections": {
         "cljAliases": ["dev", "test"]