Skip to content

feat: add Contains decorator#210

Merged
yuchem2 merged 1 commit intodevelopfrom
CARGO-390
Apr 5, 2026
Merged

feat: add Contains decorator#210
yuchem2 merged 1 commit intodevelopfrom
CARGO-390

Conversation

@yuchem2
Copy link
Copy Markdown
Member

@yuchem2 yuchem2 commented Apr 5, 2026

서브 스트링 포함 여부를 판단하는 데코레이터를 추가합니다.

@auto-assign auto-assign Bot requested review from dami0806, laggu and sezeme April 5, 2026 11:37
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new @Contains validation decorator to the express-cargo library, allowing users to verify if a string contains a specific substring. The implementation includes the core validator logic, unit tests, and extensive documentation updates across multiple languages (English, Korean, German, French, Russian). The review feedback correctly identified minor documentation inconsistencies, such as the casing of the @Optional decorator and missing backticks for code formatting in the @Alpha decorator examples, all of which provide clear improvement opportunities.

Comment thread README.ko.md Outdated
Comment thread README.ko.md Outdated
Comment thread README.md Outdated
@yuchem2 yuchem2 merged commit e9a397f into develop Apr 5, 2026
3 checks passed
@yuchem2 yuchem2 deleted the CARGO-390 branch April 5, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants