Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the @IsHash validation decorator, supporting various algorithms including MD5, SHA, and CRC32, along with corresponding documentation and tests. Review feedback recommends renaming properties in the example router for better clarity and adding explicit test cases for the crc32b algorithm to ensure full coverage.
dami0806
approved these changes
Apr 11, 2026
laggu
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
웹 서버 요청 검증에서 자주 사용되는 해시 알고리즘(MD5, SHA-1, SHA-2 계열, CRC32)만 지원하도록 작성하였습니다. SHA-3, Blake 등은 HTTP 요청 파라미터 검증에서 사용 빈도가 극히 낮아 현재 스코프에서 제외했으며, 필요시 추후 hashPatterns에 추가하는 것만으로 쉽게 확장할 수 있습니다.