readme link to QMK changed, readme text changed - #1
Open
ewendlick wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I bought two of these Meishis last night and saw that one of the links in the readme wasn't working, so I found the updated url and added that. I also changed some of the wording, but would like confirmation if it is correct.
Also, what do you think about changing "https://mechanicalkeyboards.com/shop/index.php?l=product_list&c=107" to "https://yushakobo.jp/product-category/switches/"?
昨日の夜にメイシを二枚買ってreadmeの中のリンクは４０４が発見したのでそのリンクを変更しました。ちょっと英語を変更したけど正しく情報を表すかどうか確認したいでございます。
ちなみに、readmeのスイッチについてリンクはhttps://mechanicalkeyboards.com/shop/index.php?l=product_list&c=107 から https://yushakobo.jp/product-category/switches/ にしたらどうだと思いますか？ w