Feature pull request: Mutable SVG object in runtime#70
Open
wonson wants to merge 9 commits intoBigBadaboom:masterfrom
wonson:master
Open
Feature pull request: Mutable SVG object in runtime#70wonson wants to merge 9 commits intoBigBadaboom:masterfrom wonson:master
wonson wants to merge 9 commits intoBigBadaboom:masterfrom
wonson:master
Conversation
Make public of value type classes and all SVG-Tag-related classes Move the value type classes to new files Add getters and setters for public access (Becoz of make it mutable from outside) but package-private direct access to instance variables Minor changes to getElementByXXX methods
Owner
|
Hi. Thanks for posting this. This is an interesting patch. I'm curious how you are using these changes yourself. What is it enabling you to do that you couldn't do before? |
Author
|
I have 2 major usage:
After the change is set, I render the SVG object into picture, then restore original SVG state and the another change, and so on. |
Author
|
But the code is not thoroughly tested. I only use it with some tags I've used. You'd better test the code more with your own test case. :P |
Remove caching map of id to element and class name to element (because mutable code not guarantee correct update for now)
|
This is definitely stale, but it would still be a useful feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I modify your code to make the SVG mutable, Including:
etc.
Please take a look.
I followed you from GoogleCode. You said you will parse it to DOM-tree, I dunno if it is still on. But may be you can accept this first and let people do these things first. After you finish the DOM-tree implementation, you can level up your version to 2.x.x