Add ProactiveInsightsPanel EvalCSharp layout test #1

Bigessfour · 2026-01-10T18:27:47Z

This PR adds an EvalCSharp-based xUnit test verifying ProactiveInsightsPanel layout invariants (header min height, data grid fills remaining area, overlay coverage). It also includes documentation and notes that WinForms/Syncfusion tests require a Windows host and will not run successfully in non-Windows Docker containers. Please run the MCP CI on a Windows runner and report results.

…rlay coverage)

continue · 2026-01-10T18:27:49Z

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts

Unsubscribe from All Green comments

Copilot

Pull request overview

This PR adds an EvalCSharp-based xUnit test to verify layout invariants of the ProactiveInsightsPanel WinForms control, including header minimum height, data grid positioning, and loading overlay coverage. The test uses the EvalCSharpTool to execute C# scripts within the test framework and includes documentation noting that these tests require a Windows host environment.

Changes:

Added xUnit test ProactiveInsightsPanelLayoutTests.cs that validates ProactiveInsightsPanel layout behavior
Added multiple markdown documentation files explaining the test requirements and Windows host dependency

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
ProactiveInsightsPanelLayoutTests.cs	New xUnit test that uses EvalCSharpTool to validate ProactiveInsightsPanel layout constraints
PR-REQUEST-MERGE.md	Merge request documentation noting Windows runner requirement
PR-README-PR-BODY.md	PR body template explaining the test additions
PR-OPEN-ME.md	Placeholder file to prompt PR creation
PR-AUTOGEN-PLACEHOLDER.md	Placeholder indicating automated PR generation
PR-ADD-PROACTIVE-INSIGHTS-LAYOUT-TEST.md	Summary of the layout test additions
PR-ADD-PROACTIVE-INSIGHTS-LAYOUT-TEST-README.md	Detailed README about the test implementation
PR-ADD-PROACTIVE-INSIGHTS-LAYOUT-TEST-NOTES.md	Technical notes about Windows host requirements
PR-ADD-PROACTIVE-INSIGHTS-LAYOUT-TEST-CALL-TO-ACTION.md	Call to action for maintainers to run CI on Windows

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-10T18:32:30Z

tools/WileyWidgetMcpServer/Tests/Tools/ProactiveInsightsPanelLayoutTests.cs

+            var success = json.RootElement.GetProperty("success").GetBoolean();
+            Assert.True(success, $"EvalCSharp failed: {json.RootElement.GetProperty("error").GetString()} \n {json.RootElement.GetProperty("output").GetString()}");


The error handling logic here has a potential bug. When the script execution fails, it attempts to access both "error" and "output" properties from the JSON, but if "error" is not present (e.g., when "success" is false for other reasons), this will throw a JsonException. Consider checking if these properties exist before accessing them, or handle the JsonException appropriately.

Suggested change

var success = json.RootElement.GetProperty("success").GetBoolean();

Assert.True(success, $"EvalCSharp failed: {json.RootElement.GetProperty("error").GetString()} \n {json.RootElement.GetProperty("output").GetString()}");

var root = json.RootElement;

var success = root.GetProperty("success").GetBoolean();

string errorMessage = null;

if (root.TryGetProperty("error", out var errorElement) && errorElement.ValueKind == JsonValueKind.String)

{

errorMessage = errorElement.GetString();

}

string outputMessage = null;

if (root.TryGetProperty("output", out var outputElement) && outputElement.ValueKind == JsonValueKind.String)

{

outputMessage = outputElement.GetString();

}

Assert.True(success, $"EvalCSharp failed: {errorMessage} \n {outputMessage}");

Copilot · 2026-01-10T18:32:31Z

tools/WileyWidgetMcpServer/Tests/Tools/PR-ADD-PROACTIVE-INSIGHTS-LAYOUT-TEST.md

@@ -0,0 +1,3 @@
+# ProactiveInsightsPanel Layout Test
+
+Adds an EvalCSharp-based test that validates header minimum height, grid layout, and that the loading overlay covers the data grid. This test follows the EvoCSharp/TestHelper pattern and is intended to run on a Windows host where WinForms and Syncfusion assemblies are available.


There's a typo in the embedded C# script. On line 3 in the PR description and documentation, it says "EvoCSharp" but it should be "EvalCSharp" to match the actual tool name. This appears to be a documentation typo rather than in code.

Suggested change

Adds an EvalCSharp-based test that validates header minimum height, grid layout, and that the loading overlay covers the data grid. This test follows the EvoCSharp/TestHelper pattern and is intended to run on a Windows host where WinForms and Syncfusion assemblies are available.

Adds an EvalCSharp-based test that validates header minimum height, grid layout, and that the loading overlay covers the data grid. This test follows the EvalCSharp/TestHelper pattern and is intended to run on a Windows host where WinForms and Syncfusion assemblies are available.

Copilot · 2026-01-10T18:32:31Z

tools/WileyWidgetMcpServer/Tests/Tools/ProactiveInsightsPanelLayoutTests.cs

+TestHelper.Assert(top.Height >= 60, $\"Top panel height too small: {top.Height}\");
+
+var feed = pPanel.Controls.Find(\"InsightFeedPanel\", true).FirstOrDefault() as Control;
+TestHelper.Assert(feed != null, \"InsightFeedPanel not found\");
+
+TestHelper.Assert(feed.Bounds.Top >= top.Bounds.Bottom, \"InsightFeedPanel positioned above header\");
+
+var grid = feed.Controls.Find(\"InsightsDataGrid\", true).FirstOrDefault() as Control;
+TestHelper.Assert(grid != null, \"InsightsDataGrid not found\");
+TestHelper.Assert(grid.Bounds.Height >= 100, $\"DataGrid height too small: {grid.Bounds.Height}\");


The test contains multiple hardcoded "magic numbers" (60 for minimum header height and 100 for minimum grid height) without explanation of why these specific values were chosen. Consider adding comments in the embedded C# script explaining these constraints, or extracting them as named constants to improve maintainability.

Copilot · 2026-01-10T18:32:31Z

tools/WileyWidgetMcpServer/Tests/Tools/ProactiveInsightsPanelLayoutTests.cs

+
+TestHelper.Assert(grid.Bounds.Equals(overlay.Bounds), \"Loading overlay does not match grid bounds\");
+
+overlay.Visible = false;


The test sets overlay.Visible = false on line 46 after verifying the overlay bounds, but this state change doesn't have any assertions associated with it. This line appears to be cleanup code that doesn't contribute to test validation. Consider removing it or adding a comment explaining its purpose if it's necessary for proper cleanup.

Copilot · 2026-01-10T18:32:31Z

tools/WileyWidgetMcpServer/Tests/Tools/ProactiveInsightsPanelLayoutTests.cs

+var feed = pPanel.Controls.Find(\"InsightFeedPanel\", true).FirstOrDefault() as Control;
+TestHelper.Assert(feed != null, \"InsightFeedPanel not found\");
+
+TestHelper.Assert(feed.Bounds.Top >= top.Bounds.Bottom, \"InsightFeedPanel positioned above header\");


Comparison of identical values.

Copilot · 2026-01-10T18:32:31Z

tools/WileyWidgetMcpServer/Tests/Tools/ProactiveInsightsPanelLayoutTests.cs

+            var csx = @"using System;
+using System.Linq;
+using System.Windows.Forms;
+using System.Drawing;
+using WileyWidget.WinForms.Controls;
+
+// Instantiate and layout the panel
+var pPanel = new ProactiveInsightsPanel();
+pPanel.Size = new Size(800,600);
+pPanel.CreateControl();
+pPanel.PerformLayout();
+
+var top = pPanel.Controls.Find(\"ProactiveTopPanel\", true).FirstOrDefault() as Control;


This assignment to csx is useless, since its value is never read.

Bigessfour added 9 commits January 10, 2026 11:21

Add EvalCSharp layout test for ProactiveInsightsPanel (layout and ove…

ae5a88e

…rlay coverage)

Add PR description file for layout test

3e72572

Add PR test details and Windows host note

0856f49

PR: Add ProactiveInsightsPanel layout test and docs

ff1bf23

PR: Add request to run MCP CI on Windows runner

363405a

PR body for ProactiveInsightsPanel layout test

793ca5a

Add placeholder indicating PR to run MCP CI

8adbd64

Request merge and Windows runner CI

2e31af1

PR placeholder - please open PR

c8d4087

Copilot AI review requested due to automatic review settings January 10, 2026 18:27

Copilot started reviewing on behalf of Bigessfour January 10, 2026 18:28 View session

Copilot AI reviewed Jan 10, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ProactiveInsightsPanel EvalCSharp layout test #1

Add ProactiveInsightsPanel EvalCSharp layout test #1

Uh oh!

Bigessfour commented Jan 10, 2026

Uh oh!

continue bot commented Jan 10, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 10, 2026

Uh oh!

Copilot AI Jan 10, 2026

Uh oh!

Copilot AI Jan 10, 2026

Uh oh!

Copilot AI Jan 10, 2026

Uh oh!

Copilot AI Jan 10, 2026

Uh oh!

Copilot AI Jan 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		var success = json.RootElement.GetProperty("success").GetBoolean();
		Assert.True(success, $"EvalCSharp failed: {json.RootElement.GetProperty("error").GetString()} \n {json.RootElement.GetProperty("output").GetString()}");

-            var success = json.RootElement.GetProperty("success").GetBoolean();
-            Assert.True(success, $"EvalCSharp failed: {json.RootElement.GetProperty("error").GetString()} \n {json.RootElement.GetProperty("output").GetString()}");
+            var root = json.RootElement;
+            var success = root.GetProperty("success").GetBoolean();
+            string errorMessage = null;
+            if (root.TryGetProperty("error", out var errorElement) && errorElement.ValueKind == JsonValueKind.String)
+            {
+                errorMessage = errorElement.GetString();
+            }
+            string outputMessage = null;
+            if (root.TryGetProperty("output", out var outputElement) && outputElement.ValueKind == JsonValueKind.String)
+            {
+                outputMessage = outputElement.GetString();
+            }
+            Assert.True(success, $"EvalCSharp failed: {errorMessage} \n {outputMessage}");

		@@ -0,0 +1,3 @@
		# ProactiveInsightsPanel Layout Test

		Adds an EvalCSharp-based test that validates header minimum height, grid layout, and that the loading overlay covers the data grid. This test follows the EvoCSharp/TestHelper pattern and is intended to run on a Windows host where WinForms and Syncfusion assemblies are available.


		TestHelper.Assert(grid.Bounds.Equals(overlay.Bounds), \"Loading overlay does not match grid bounds\");

		overlay.Visible = false;

Add ProactiveInsightsPanel EvalCSharp layout test #1

Are you sure you want to change the base?

Add ProactiveInsightsPanel EvalCSharp layout test #1

Uh oh!

Conversation

Bigessfour commented Jan 10, 2026

Uh oh!

continue bot commented Jan 10, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant