Add support for trend analysis, enriching examples and docs#18
Merged
Conversation
Collaborator
|
Nice job on this! The examples are super clear and make it really easy to follow along. |
Owner
Author
|
@Gatmatz good to go? I will need to fix a small style formatting issue that makes automated styling tests to fail. Anything else apart from that? Otherwise I am going to merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for trend analysis as part of the data quality measurements (DQMs) suite. Trend analysis is implemented by computing the slope of line that best fits the elements in the window. Implementing this new feature uncovered an small bug regarding the way Pathway (and not) timestamps are handled. This bug is currently out of scope for the current PR but will be fixed soon.
Type of Change
Testing
examples/trend_analysis.pycan be executed without external dependencies for testing purposes if needed.Checklist
Fixes #12