Skip to content

[BUG-FIX] Wrap set of missing values in a tuple before passing it to pw.apply_with_type#23

Merged
Bilpapster merged 1 commit into
mainfrom
bugfix-missing-count
Oct 6, 2025
Merged

[BUG-FIX] Wrap set of missing values in a tuple before passing it to pw.apply_with_type#23
Bilpapster merged 1 commit into
mainfrom
bugfix-missing-count

Conversation

@Bilpapster

Copy link
Copy Markdown
Owner

Description

Fixes #21

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Testing

  • I have tested this change locally
  • I have added tests that prove my fix is effective or that my feature works
  • All new and existing tests pass

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@Bilpapster Bilpapster requested a review from Gatmatz October 5, 2025 17:58
@Bilpapster Bilpapster self-assigned this Oct 5, 2025
@Bilpapster Bilpapster changed the title [BUG-FIX] Wrap set of missing values in a tuple to pass as in pw.apply_with_type [BUG-FIX] Wrap set of missing values in a tuple before passing it to pw.apply_with_type Oct 5, 2025

@Gatmatz Gatmatz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job identifying and fixing the bug. This looks good to me — we can go ahead and merge.

@Bilpapster

Copy link
Copy Markdown
Owner Author

Thanks George! Just enabled auto-merge at the repository level, so, hopefully we can have PRs that are accepted to be merged automatically from now on.

@Bilpapster Bilpapster merged commit 0395e05 into main Oct 6, 2025
3 of 4 checks passed
@Bilpapster Bilpapster deleted the bugfix-missing-count branch October 6, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] missing_count and missing_fraction DQMs run into pathway TypeError exception

2 participants