Improve central logging management and enrich docs#29
Conversation
Gatmatz
left a comment
There was a problem hiding this comment.
Very clean and nice work, Vassilis! When you have a moment, please take a look at my comments.
| self, | ||
| measure: pw.ColumnExpression | ReducerExpression, | ||
| assess: str | Callable[[Any], bool] | None = None, | ||
| must_be: str | Callable[[Any], bool] | None = None, |
There was a problem hiding this comment.
This may break compatibility with the pre-task version of StreamDaQ. Specifically, it introduces a breaking API change for users who call StreamDaQ.check(assess=...), as this would now raise a TypeError.
To maintain backward compatibility, consider accepting both keywords (assess and must_be) during a transition period.
There was a problem hiding this comment.
I did not clarify it enough, sorry. This check() function was added in the same PR that introduced the Task API. Note that the add() function still has the assess parameter, like it used to be.
In other words, this change tries to align the check() function of Task (which correctly uses must_be), with the check() function of StreamDaQ (which is relatively new, not advertised and is not expected to affect users).
Does this make sense or am I missing something here?
65f98bd to
0b8b9e9
Compare
Description
Created a centralized logging management mechanism with configurable levels (e.g., INFO, DEBUG, ERROR). Also renamed
assessparameter tomust_bein thecheck()function ofStreamDaQwhich slipped through the previous PR for consistency. Thecheck()function ofTaskalready uses themust_beparameter. Also updated thedocs/concepts/andexamples/directories.Type of Change
Testing
Checklist
Issues
Fixes #27 and is mainly based on the implementation provided in #28