Add HDR OpenEXR cube face export - #4
Closed
andy83 wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implementation
BinaryConstruct already bakes its cubemap into a
HalfFloatTyperender target. The new path reads each face into aUint16Array, wraps that half-float data in a Three.jsDataTexture, and encodes it with Three.js'EXRExporter. No 8-bit PNG or other LDR intermediate is involved.Faces are read and encoded sequentially so the 4096×4096 export does not retain six additional uncompressed conversion buffers at once.
Verification
npm test: 17 files, 135 tests passednpm run build: passednpm run lint: passed with the repository's existingreact(only-export-components)warning insrc/ui/SpritesTab.tsx