UX Improvements to Views #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Moved views selection to sidebar
…up 2 lines only on dark mode 🤷
…nto view-improvements
…nto view-improvements
Levi-Lesches
requested changes
Sep 19, 2024
There was a problem hiding this comment.
Looking good so far.
- Due to the draggable elements, it's impossible to scroll the list of views using the touch screen. This is not as important on desktop but will be on mobile or the on-rover touch screen we plan on using.
- We've gotten feedback from the e-board to keep the dropdown as well. A bit annoying code-wise, but I see their side UI-wise -- it wasn't taking up much space and made it easy to say "change this display" without moving your mouse or focusing too far away
- We'd need the video icons back because they indicate the connection status. Make sure to include it in both the dropdown and the side menus
- While you're at it, can you also add the icons for the non-camera pages to the dropdown as well?
Again, great work, people really like this. And we can merge this before presets are finished, though it will also go in here
Levi-Lesches
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.