-
Notifications
You must be signed in to change notification settings - Fork 2
Fixed arm laser light displaying incorrect state #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We've tried this before, but had the issue that the UI isn't responsive to what you press, which makes people think the Dashboard is broken. Currently, the metrics sidebar shows what the rover is actually doing while the switch we have now shows what you're trying to do. Not saying that's the best answer but an unresponsive UI isn't great either Also, +1 for including a pic in the PR, -1 for keeping your auto-formatter on! It's tempting I know, but it distracts from the actual changes of the PR, and is best done separately where it can be insta-approved instead |
One other option I thought of (which I did in my other dashboard) is display what the user selected but have a check or X icon next to it to indicate whether or not the data the rover has is the one being displayed Also where did I screw up formatting? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks. I just changed the warning into a sync icon since it's not "bad", per-se. And I updated the tooltip to be a bit simpler.
Also where did I screw up formatting?
Eg, some parts of the IK math. It's not bad formatting, it's an improvement, just makes reviews a bit more distracting is all.
Instead of having a switch that can display the incorrect laser state, it now uses toggle buttons and only displays the laser state of the gripper data received