Logs page improvements #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Levi-Lesches
previously approved these changes
Sep 25, 2024
|
What's the reason for adding the ping button? |
|
Because if SSH hangs, it can be useful to debug why. Also, ping shows latency. My debugging process is always: 1) ping to ensure the device is alive, 2) ssh inside and verify that the Dart programs are still running. Which is why I also removed the condition on |
Levi-Lesches
previously approved these changes
Sep 25, 2024
Levi-Lesches
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds icons underneath each device indicating connection status, connection strength, and a button to Open SSH
SSH is only supported on windows and if the device is connected (otherwise powershell freezes up)