Add battery warning display for low voltage #235
Conversation
manavsuresh
added
type: enhancement
|
| child: Wrap( | ||
| crossAxisAlignment: WrapCrossAlignment.center, | ||
| alignment: WrapAlignment.spaceBetween, | ||
| children: [ | ||
| MessageDisplay(showLogs: showLogs), | ||
| const StatusIcons(), | ||
| ], | ||
| child: SizedBox( | ||
| height: 48, | ||
| child: Row( | ||
| children: [ | ||
| Expanded( | ||
| child: Align( | ||
| alignment: Alignment.centerLeft, | ||
| child: MessageDisplay(showLogs: showLogs), | ||
| ), | ||
| ), | ||
| const Expanded( | ||
| child: Center( | ||
| child: BatteryWarningDisplay(), | ||
| ), | ||
| ), | ||
| const Expanded( | ||
| child: Align( | ||
| alignment: Alignment.centerRight, | ||
| child: StatusIcons(), | ||
| ), | ||
| ), | ||
| ], | ||
| ), |
There was a problem hiding this comment.
While this would make the battery display centered, if the window was made more narrow, this would cause issues with proportions when some widgets stopped fitting. Look into using a NavigationToolbar instead which should handle this better.
There was a problem hiding this comment.
I still get the same RenderFlex overflow issue when the window size is smaller than the minimum required width with the NavigationToolbar Implementation.
The NavigationToolbar currently just wraps the existing components and doesn't manage layout scaling. So, I guess, unless I update the individual widget properties to adapt to the available space. Or is there a better way to do this?
The RenderFlex overflow error was already occurring before the battery indicator implementation when the window was smaller than required.
| @override | ||
| void initState() { | ||
| super.initState(); | ||
| _footerModel = FooterViewModel(); |
There was a problem hiding this comment.
To avoid data possibly getting out of sync, the footer view model should be passed into the widget instead of having it be created in the state
2 participants
-Added Critical Indicator
-Added Warning Indicator with blinking Animation
-The values are from the preset values for the rover.