Skip to content

Conversation

niooii
Copy link
Contributor

@niooii niooii commented Sep 12, 2025

Rewrote vision program as a CLI for ease of use and better testing.

example output:

uv run cli.py 

usage: cli.py [-h] command ...

positional arguments:
  command
    unit-test  Test how a model does on test images
    test       Send frames from a video stream to the server
    server     Start the analyzer server
    train      Train a YOLO model on a dataset

options:
  -h, --help   show this help message and exit

@niooii niooii requested a review from a team as a code owner September 12, 2025 01:03
@github-actions github-actions bot added the vision Changes to the Vision program label Sep 12, 2025
lregueiferos
lregueiferos previously approved these changes Sep 12, 2025
Copy link
Contributor

@lregueiferos lregueiferos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go.

@Gold872
Copy link
Member

Gold872 commented Sep 12, 2025

How will this be started with systemd? I don't think this is ready to merge just yet

@lregueiferos lregueiferos linked an issue Sep 12, 2025 that may be closed by this pull request
@lregueiferos lregueiferos dismissed their stale review September 12, 2025 02:35

start with systemd

@lregueiferos
Copy link
Contributor

lregueiferos commented Sep 12, 2025

How will this be started with systemd? I don't think this is ready to merge just yet
@Gold872
I don't think that the vision program needs to be run as a service since it is not always being used. Instead, we can call the vision program from within autonomy, as that is the only time that it will be running.

@niooii
Copy link
Contributor Author

niooii commented Sep 12, 2025

How will this be started with systemd? I don't think this is ready to merge just yet

how do we start it w systemd right now? it should be very similar to that, since this is just running cli.py

@lregueiferos
Copy link
Contributor

@niooii you can add the program to systemd by changing line 68 of program.dart to reflect the new method for starting the program. additionlly if we can use uv on the jetson change allprograms.dart to use uv instead of pip.

@niooii
Copy link
Contributor Author

niooii commented Sep 13, 2025

@niooii you can add the program to systemd by changing line 68 of program.dart to reflect the new method for starting the program. additionlly if we can use uv on the jetson change allprograms.dart to use uv instead of pip.

OK. wasn't planning on using uv though, i just use it for development. I remember there were some issues with uv in the past, so running it with python should be fine. Though I forgot to change requirements txt

@niooii
Copy link
Contributor Author

niooii commented Sep 14, 2025

just pushed a quick workaround (bin.main will run python3 -m cli server) to make it compatible w how we run things right now

@niooii niooii requested a review from lregueiferos September 14, 2025 03:24
Copy link
Contributor

@lregueiferos lregueiferos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add the Cuda version of Torch to the Requirements.txt file.

lregueiferos
lregueiferos previously approved these changes Sep 17, 2025
Copy link
Contributor

@lregueiferos lregueiferos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and has been tested.

@niooii niooii requested a review from lregueiferos September 24, 2025 20:44
Copy link
Contributor

@lregueiferos lregueiferos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@niooii niooii merged commit 185be84 into main Sep 24, 2025
2 checks passed
@niooii niooii deleted the vision-cli branch September 24, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vision Changes to the Vision program

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vision program rework

3 participants