Add missing C++ standard library includes#448
Conversation
|
Hi @stanbot8, Thanks for the PR! I checked both headers and they do directly use symbols:
So adding an explicit Could you also add a short note on whether you hit a concrete build failure? That context would be helpful for the PR history. |
|
Hi @stanbot8, the CI issue that prevented macos-system-ci and ubuntu-system-ci from running has been fixed on main. Could you please update your PR branch with the latest main (merge main into your branch, or rebase onto main) and push? |
94c2d73 to
938c709
Compare
|
Hi @sportokalidis, I've rebased all my open PRs onto the latest main. CI should be able to run on them now. |
sportokalidis
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for your contribution!
log_range_param.h and range_param.h rely on <cmath> being transitively included through other headers. Adding explicit includes ensures correct builds regardless of which headers are pulled in by dependencies.
66c2482 to
3e5865b
Compare
Summary
Added explicit
#include <cmath>tolog_range_param.handrange_param.h. These headers use symbols from<cmath>but relied on transitive includes, which can break with different compilers or standard library versions.Test plan