unpin torchmetrics#38
Merged
Merged
Conversation
mmdanziger
force-pushed
the
unpin_torechmetrics
branch
from
8c5f1e4 to
071c3ad
Compare
Removes dependency on MetricCollection.pop() which is absent in
torchmetrics>=1.2, unblocking the torchmetrics unpin. Callers pass
exclude={"perplexity"} when multiple tasks share a metric_key.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
mmdanziger
force-pushed
the
unpin_torechmetrics
branch
from
071c3ad to
54db755
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
torchmetrics was pinned to 1.1 which prevents integration into algorithm-nexus since it collides with other packages.
This PR unpins its. The only effect I found is removed "pop" in MetricCollection which is bypassed by rebuilding the metric collection where needed.