Better names#15
Merged
Merged
Conversation
rafaqz
reviewed
Apr 27, 2026
| | `T_target` | `SteppedParameter` — current/max preferred temperature | TPREF / T_F_max | | ||
| | `T_active_min/max` | Foraging temperature range | TMINPR / TMAXPR (T_F_min / T_F_max) | | ||
| | `T_bask` | Minimum basking temperature | TBASK (T_B_min) | | ||
| | `T_bask_min` | Minimum basking temperature | TBASK (T_B_min) | |
Member
There was a problem hiding this comment.
I'll merge this anyway but note we need to decide on T_ or _temp or _temperature and stick with it
Member
There was a problem hiding this comment.
I moved away from these X_ prefixes everywhere else
Contributor
Author
There was a problem hiding this comment.
It does make for much longer names and people are used to T_ but I'm happy to just do _temperature everywhere so it's consistent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor of names for both endotherm and ectotherm code, including new IPOPT routine for endotherm - consistent with latest pull requests on HeatExchange.jl and BiophysicalGeometry.jl