Skip to content

Conversation

kedarkarkee
Copy link
Contributor

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

The change upgrades dart_style package to version ^3.0.1 to support for dart's new tall style formatter.

Alternate Designs

None

Why Should This Be In Core?

To support new tall formatter

Benefits

This makes the spider package usable with latest freezed and injectable generator since those package also use dart_style: ^3.0.1

Possible Drawbacks

If the users want old formatter with short syntax then it won't be available.

Verification Process

What process did you follow to verify that your change has the desired effects?

  • I just ran tests and all are passing

Applicable Issues

None

@BirjuVachhani
Copy link
Owner

Thanks for the PR. It would be better to offer an option to configure this behavior as there's a lot of opinion going on about the new formatter style and some people may prefer the old way. However this still a good PR.

@BirjuVachhani BirjuVachhani merged commit 1befdad into BirjuVachhani:main May 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants