Skip to content

Try using CE_NATIVE on S types #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bisaloo merged 4 commits into from
Jul 19, 2026
Merged

Try using CE_NATIVE on S types #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a72d717
Try using CE_NATIVE for S type
Bisaloo Jul 18, 2026
9e36397
Run only relevant benchmarks
Bisaloo Jul 18, 2026
e86216f
Revert "Run only relevant benchmarks"
Bisaloo Jul 18, 2026
85648f5
Bump version
Bisaloo Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: grumpy
Title: Read 'NumPy' '.npy' and '.npz' Files
Version: 0.1.1.9000
Version: 0.1.1.9001
Authors@R: c(
person("Hugo", "Gruson", , "hugo.gruson+R@normalesup.org", role = c("aut", "cre", "cph"),
comment = c(ORCID = "0000-0002-4094-1476")),
Expand Down
4 changes: 2 additions & 2 deletions src/type_conversion.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,9 +195,9 @@ SEXP type_convert_string(SEXP input, SEXP _n_bytes) {
// We cannot do one without the other as strings may not be NUL terminated (truncated) and
// mkCharLenCE complains about NUL characters in the string.
if (len > (size_t)n_bytes)
SET_STRING_ELT(data, i, mkCharLenCE(field, n_bytes, CE_BYTES));
SET_STRING_ELT(data, i, mkCharLenCE(field, n_bytes, CE_NATIVE));
else
SET_STRING_ELT(data, i, mkCharCE(field, CE_BYTES));
SET_STRING_ELT(data, i, mkCharCE(field, CE_NATIVE));
}

UNPROTECT(1);
Expand Down
Loading