Skip to content

Conversation

@usiegl00
Copy link
Contributor

@usiegl00 usiegl00 commented Dec 2, 2021

Card

See issue #528

Details

This breaks the shell command.
The shell command works with the --no-pty flag.
There is some discussion here on how to spawn a pty in a daemon.

@moloch--
Copy link
Collaborator

moloch-- commented Dec 2, 2021

We'll need build constraints around the platform specific implant code.

@moloch-- moloch-- self-assigned this Dec 2, 2021
@moloch-- moloch-- added the v1.5.0 label Dec 2, 2021

// SideloadFile - Create a file for use with Sideload
func SideloadFile(data []byte) (string, error) {
fdPath := fmt.Sprintf("/tmp/.%s", randomString(10))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the stdlib create tmp file please.

@moloch--
Copy link
Collaborator

moloch-- commented Dec 2, 2021

For shell, we can add a check to see if the current sessions' implant config is a daemon and automatically pass in --no-pty

@usiegl00 usiegl00 requested a review from moloch-- December 3, 2021 06:44
@usiegl00
Copy link
Contributor Author

This pr has been here for a while now, are there any changes you need to get this across the line?

@moloch--
Copy link
Collaborator

Oh yes, sorry I can review shortly. I think I wanted to make a couple small tweaks but I can probably take care of them.

@usiegl00
Copy link
Contributor Author

Thanks, let me know if you want any assistance.

@rkervella
Copy link
Member

@usiegl00 when you find some time, can you try to resolve the conflicts with the stage branch? I'll merge once the conflicts are resolved.

@moloch--
Copy link
Collaborator

moloch-- commented Nov 4, 2022

It looks like most of them are in generated code, I can maybe resolve them.

@moloch-- moloch-- added v1.6.x and removed v1.5.0 labels Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants