chore: doc comments on generated Options builders (#124) - #132
Merged
Conversation
Regenerated from datamaxi-codegen with doc comments emitted on Options builder setters (123 setters now documented). Generated code no longer relies on missing_docs suppression for the Options builders. Closes #124
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regenerated
src/generated.rsfrom datamaxi-codegen with doc comments now emitted on theOptionsbuilder setter methods (CexCandleOptions::market,::interval,::from,::to, and 119 more — 123 setters total). The generated Options builders no longer rely onmissing_docssuppression.Generator-side change: Bisonai/datamaxi-codegen#111. Merge that first — this PR is the mechanical regen output.
Diff is purely +123
///lines ingenerated.rs; no wire/type/contract changes (tests/generated_contract.rsunchanged).Note:
missing_docswas already absent from the#[allow(...)]onpub mod generated(the issue body predates that); the module stays#[doc(hidden)]. This PR makes the builders carry real docs rather than lean on the hidden-module suppression.Test plan
cargo fmt --check,cargo build --all-features,cargo clippy --all-features— cleancargo test --all-features— 228 passedcargo doc --all-features— no new warnings (9 pre-existing intra-doc-link warnings in hand-written code are unrelated to this change)Closes #124