Skip to content
This repository was archived by the owner on Dec 7, 2023. It is now read-only.

Change logic for metadata info (use constant value and version)#38

Open
dkovalenkoI wants to merge 11 commits into
mainfrom
dkovalenkol/AT-1454-APPLICATION-NAME
Open

Change logic for metadata info (use constant value and version)#38
dkovalenkoI wants to merge 11 commits into
mainfrom
dkovalenkol/AT-1454-APPLICATION-NAME

Conversation

@dkovalenkoI
Copy link
Copy Markdown

@dkovalenkoI dkovalenkoI commented Aug 15, 2023

Summary

JDBC - Application Name Reporting

Description

Use static application name for metrics (userAgent information).
The name is added to the agent suffix in the following format:
Constants.UA_ID_PREFIX + TimestreamDriver.DRIVER_VERSION)
Where UA_ID_PREFIX is "ts-jdbc." and the version contains major and minor information

Related Issue

N/A

Tests performed/created

N/A

Additional Reviewers

@alexeytemnikov

@forestmvey
Copy link
Copy Markdown

I don't believe all 11 commits are relevant to this PR. It makes it difficult to review, does origin/main needs to be brought up to speed with upstream/main. To avoid this we could merge into a new branch that tracks upstream/main and push that to upstream after being merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants