Adds Valkey Support#1
Open
MatthiasHowellYopp wants to merge 1 commit into
Open
Conversation
tokiwadai
reviewed
Nov 11, 2025
tokiwadai
left a comment
tokiwadai
left a comment
There was a problem hiding this comment.
Put some small comments if you won't mind. Thanks!
jbrinkman
reviewed
Nov 17, 2025
jbrinkman
left a comment
jbrinkman
left a comment
There was a problem hiding this comment.
It looks like we are missing tests for Valkey. We should review the existing tests and make sure that we have similar coverage for Valkey.
MatthiasHowellYopp
force-pushed
the
valkey-support
branch
from
b8cfb29 to
a46f96d
Compare
Author
|
@jbrinkman I've updated tests so that the work for both valkey and redis - there are two scripts that don't work in main and I am waiting for a response from the recall owner. |
upped reasonable size
MatthiasHowellYopp
force-pushed
the
valkey-support
branch
from
525eadd to
48cdce4
Compare
jbrinkman
approved these changes
Nov 24, 2025
jbrinkman
left a comment
jbrinkman
left a comment
There was a problem hiding this comment.
LGTM once all comments are resolved. 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the changes to support either valkey or redis depending on environment variables.