license: replace Shift Apache headers #3716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benma
force-pushed
the
license-header
branch
from
d6dd0b9 to
865f7ee
Compare
added 3 commits
December 12, 2025 19:57
Replace the existing Shift Crypto/Shift Devices Apache-2.0 boilerplate header blocks with the standard SPDX License Identifier tag: "SPDX-License-Identifier: Apache-2.0". This is better than the previous multi-line text header because it is machine-readable, unambiguous, and widely understood by tooling (scanners, compliance automation), while keeping files smaller and reducing header churn.
benma
force-pushed
the
license-header
branch
from
b43bc66 to
fad9f09
Compare
cedwies
requested changes
Dec 13, 2025
| @@ -1,4 +1,5 @@ | |||
| Copyright 2018-2020 Shift Cryptosecurity AG, Switzerland. All rights reserved. | |||
Collaborator
There was a problem hiding this comment.
Missed to remove a line? Or is this intentional? If so, could you explain why?
Contributor
Author
There was a problem hiding this comment.
I want to extend, not replace. Maybe it should be done on one line though? 🤔
Collaborator
There was a problem hiding this comment.
Ah, understood. In that case I dont have a strong opinion, fine to me as is
cedwies
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the existing Shift Crypto/Shift Devices Apache-2.0 boilerplate header blocks with the standard SPDX License Identifier tag: "SPDX-License-Identifier: Apache-2.0".
This is better than the previous multi-line text header because it is machine-readable, unambiguous, and widely understood by tooling (scanners, compliance automation), while keeping files smaller and reducing header churn.