Skip to content

Conversation

@shonsirsha
Copy link
Collaborator

@shonsirsha shonsirsha commented Dec 15, 2025

Screenshot 2025-12-15 at 09 42 06 Screenshot 2025-12-15 at 09 42 12

Search by account name:

Screenshot 2025-12-15 at 09 42 16

@shonsirsha shonsirsha force-pushed the frontend-responsive-account-selector branch from b5ac367 to 95d32cd Compare December 15, 2025 08:33
@shonsirsha shonsirsha changed the title frontend: WIP responsive grouped account selector frontend: responsive grouped account selector Dec 15, 2025
@shonsirsha shonsirsha marked this pull request as ready for review December 15, 2025 08:43
@shonsirsha shonsirsha force-pushed the frontend-responsive-account-selector branch from 95d32cd to 0854890 Compare December 15, 2025 08:45
@shonsirsha
Copy link
Collaborator Author

I'll squash the 2nd commit, just for clarity -- there I extracted the common styles between the grouped fullscreen mobile selector and the non-grouped one into one file, and use them accordingly.


return (
<>
<h1 className="title text-center">{title}</h1>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other component that is dropdown on desktop or full screen on mobile is
input-with-dropdown.tsx. That one uses Dropdown with mobileFullScreen prop.

But here we use Select + custom full screen, and no Dropdown component and there is some code duplication.

I hoped we could get a reusable Dropdown/Fullscreen component that we can use everywhere.

Did you look into what it would take make a generic Dropdown component that can go fullscreen?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm fair enough. I was focused on the component itself (groupedaccountselector), but this component is already not really reusable (only for account selector, nothing else).

We should have instead a reusable "groupeddropdown" which also accepts mobileFullscreen. Or maybe extend the current dropdown so grouping works. Then we use it here instead of the default Select.

@shonsirsha shonsirsha force-pushed the frontend-responsive-account-selector branch 2 times, most recently from ee3e5f5 to b5f54bd Compare December 16, 2025 06:11
@shonsirsha
Copy link
Collaborator Author

Thank you for the review @thisconnect . Addressed your comment: I extended our Dropdown (and also its mobilefullscreen component) so it works for grouped options. Also rebased. PTAL 🙏

Searchable responsive grouped amount selector (on mobile).
Search by account name.
@shonsirsha shonsirsha force-pushed the frontend-responsive-account-selector branch from b5f54bd to 3d087ae Compare December 16, 2025 06:18
Copy link
Collaborator

@thisconnect thisconnect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, tested on Android LGTM

@shonsirsha shonsirsha merged commit 2347c9b into BitBoxSwiss:master Dec 16, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants