Skip to content

chore: center layout elements and align widths#15

Open
Yasansvr wants to merge 2 commits intodevfrom
ui-layout
Open

chore: center layout elements and align widths#15
Yasansvr wants to merge 2 commits intodevfrom
ui-layout

Conversation

@Yasansvr
Copy link
Copy Markdown
Collaborator

No description provided.

@Yasansvr Yasansvr requested a review from moakilodash April 24, 2026 13:22
@moakilodash
Copy link
Copy Markdown
Collaborator

looks good to me, just link the issue you're addressing with this pr and resolve the comments i've made

Comment thread shellshop/app.py
height: 3;
width: 80;
border: round #2f8f83;
background: ansi_default;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicking here, but keep whitespaces consistent

Comment thread shellshop/app.py Outdated
#hero-container {
width: 100%;
height:14;
align: center middle; /* This centers the #tabs box horizontally */
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the comment from this line

@moakilodash
Copy link
Copy Markdown
Collaborator

@Yasansvr now also mention the issue you were trying to solve with this pr by commenting the number of the issue with a #.
if this pr is not resolving any open issues, try to open one first, mention it here and then we can proceed to merge your changes to dev branch.

@Yasansvr
Copy link
Copy Markdown
Collaborator Author

fix #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants