Skip to content

fix(mapa): abrir accesos peatonales a los jardines de la ciudad - #18

Merged
leocagli merged 3 commits into
Bitcoindefi:mainfrom
s6pa1rta3n-lab:fix/issue-5-sealed-gardens
Aug 26, 2026
Merged

leocagli merged 3 commits into
Bitcoindefi:mainfrom
s6pa1rta3n-lab:fix/issue-5-sealed-gardens

Conversation

@s6pa1rta3n-lab

@s6pa1rta3n-lab s6pa1rta3n-lab commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Los jardines de la ciudad dibujaban un perimetro continuo con border(), dejando 4946 celdas caminables completamente selladas sin entrada para el jugador.

Se agregaron cuatro accesos abiertos en las direcciones cardinales siguiendo el mismo patron que civicSquare(), permitiendo que el jugador camine hacia el interior del jardin y recorra los senderos y el estanque central.

Tambien se agrego un test en test/index.js que valida la alcanzabilidad de los jardines desde el spawn.

Closes #5

Comment thread test/index.js Outdated
@leocagli

Copy link
Copy Markdown
Collaborator

This one no longer merges into main.

main moved a lot since it was opened: the save slot system, the coliseum map, the
world boss, and several render fixes all landed. The branch conflicts, so I cannot
test what the merged result would do.

If you rebase it on today's main I will re-run it and report the numbers here. The
current baseline is 65 tests and 515 assertions in green.

One thing worth checking while rebasing: another contributor opened a pull request
for the same issue, so it is worth a look before spending time on the conflict, in
case the work is already covered.

Los jardines dibujaban un perimetro continuo con border(), sellando 4946 celdas caminables e impidiendo que el jugador pueda entrar.

Se agregan cuatro accesos abiertos en las direcciones cardinales similares a los de civicSquare(), conectando los senderos exteriores con el interior del jardin y el estanque central.

Fixes Bitcoindefi#5
@s6pa1rta3n-lab
s6pa1rta3n-lab force-pushed the fix/issue-5-sealed-gardens branch from 3ec5bf8 to 606e88d Compare August 25, 2026 18:06
@s6pa1rta3n-lab

Copy link
Copy Markdown
Contributor Author

Rebased onto latest main, resolved conflicts, and verified npm test and npm run lint are green.

@gitar-bot

gitar-bot Bot commented Aug 25, 2026

Copy link
Copy Markdown
Code Review ✅ Approved 1 resolved / 1 findings

Opens pedestrian access points to the city gardens and adds a reachability test, addressing the unmapped tile crash finding. No remaining issues found.

✅ 1 resolved
Bug: Reachability test crashes on unmapped ' ' tile before assertions

📄 test/index.js:1061
The new BFS reads TILES[city.rows[y][x]].solid without the || NOWHERE guard that production tileAt uses. Building/plaza interiors and the fountain surround are painted with space characters (' ') that are walkable-adjacent, and ' ' is not a key in TILES. I confirmed the walk reaches a space at (147,89) — before ever touching the gardens — so TILES[' '] is undefined and .solid throws a TypeError, making the test error out instead of validating anything (the four t.ok assertions never run). Guard the lookup so unknown glyphs count as solid, matching tileAt. (The map.js fix itself is correct: with the guard the four garden points are reachable.)

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Important

Your trial ends in 7 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.

Was this helpful? React with 👍 / 👎 | Gitar

@s6pa1rta3n-lab

Copy link
Copy Markdown
Contributor Author

Rebased onto current main, resolved any conflicts, and verified all tests pass cleanly.

@s6pa1rta3n-lab

Copy link
Copy Markdown
Contributor Author

Rebased on latest main, resolved any conflicts, and ensured all tests and linting pass locally.

@leocagli
leocagli merged commit 5e02ac5 into Bitcoindefi:main Aug 26, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

los dos jardines de la ciudad estan sellados: 5025 celdas sin entrada

2 participants