fix: remove oversized fieldGate override and rely on > tile transition - #19
Merged
leocagli merged 1 commit intoAug 25, 2026
Merged
Conversation
Code Review ✅ ApprovedRemoves the oversized fieldGate bounding box and override logic, allowing map transitions to trigger naturally through standard tile interaction. No issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
This was referenced Aug 25, 2026
s6pa1rta3n-lab
pushed a commit
to s6pa1rta3n-lab/runa
that referenced
this pull request
Aug 28, 2026
Reconstruido sobre el main de hoy. La version anterior entro en conflicto cuando se mergeo el PR Bitcoindefi#19, que saco el bloque del `fieldGate`: ahi nacia uno de los tres `new Field(...)` que esta rama sembraba. Ahora quedan dos y se siembran los dos. El campo se sembraba con el valor por defecto, asi que cada salida a la pradera era exactamente la misma pradera. Es la issue Bitcoindefi#3, y seguia viva en main: los `new Field(...)` no llevaban semilla. Ahora la semilla sale del numero de ledger de Stellar partido en bloques de un dia. Todos los que jueguen hoy caminan el mismo campo, con los mismos bichos en los mismos lugares. Manana es otro. Verificado: dos clientes independientes sacan seed 3310838056 para el dia 250, y esa semilla produce 28 bichos identicos. Por que la cadena y no un servidor: la semilla tiene que ser igual para todos, cambiar sola, y sobre todo que no la haya elegido nadie. Las dos primeras las da cualquier servidor. La tercera exige que el jugador pueda comprobarlo por su cuenta, y por eso sirve un contador publico que ni el dueno del juego puede mover. No pide billetera, ni fondos, ni transacciones. Es un GET. Sin internet cae a una semilla local derivada del jugador, que igual arregla la issue Bitcoindefi#3 para el que juega solo. La consulta no bloquea ningun cuadro y nadie la espera. @stellar/stellar-sdk no carga en Bare: pide TextDecoder y despues Event. Se usa @stellar/stellar-base empaquetado con --conditions=browser, que es lo que hace que @noble/curves deje de pedir node:crypto. Los tres globals que faltan los pone lib/stellar.js. Todo explicado en vendor/README.md. Ocho tests nuevos y ninguno toca la red: un test que pida la semilla de verdad se pone rojo cuando el RPC publico tiene un mal dia, y eso no prueba el juego sino el clima. main hoy 65 tests, 517 asserts con esto 73 tests, 532 asserts lint limpio y git diff --check limpio. Refs Bitcoindefi#3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #4
Previously, the
fieldGatebounding rectangle inlib/map.jscovered a 61x15 area spanning across the entire gatehouse, including 864 solid wall tiles. An override inlib/game.jsintercepted any movement attempt into this rectangle prior to collision detection, causing players bumping into the gatehouse walls to accidentally teleport to the meadow.Solution
fieldGatebounding box fromMAPS.cityinlib/map.js.fieldGatecheck frommove()inlib/game.js.>glyph at(160, 194).test/index.jsto verify proper transition on stepping onto>and that walking into gatehouse walls correctly blocks movement without teleporting.