Add contributions by contributor metric and tests #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dicortazar
force-pushed
the
contributors
branch
from
e4635e8 to
b71d3bd
Compare
Signed-off-by: Daniel Izquierdo Cortazar <[email protected]>
dicortazar
force-pushed
the
contributors
branch
from
b71d3bd to
639fe8c
Compare
alpgarcia
suggested changes
Oct 14, 2020
Contributor
alpgarcia
left a comment
alpgarcia
left a comment
There was a problem hiding this comment.
Tested and working. Just one minor change in the documentation side to make it clearer. It would be great to have an associated issue describing the metric and why we are adding it.
For future PRs, imho we should use forks for proposing changes and upstream branches for different versions of the project if any (for instance stable, dev, releases, etc.).
Thanks @dicortazar !
| :param end_date: date until we want to counts contributions to (inclusive). | ||
| `None` by default, means count everything from `start_date`. | ||
| :param exclude_bots: whether or not to exclude contributions by bots | ||
| :returns: the number of contributions sent to the specified data source. |
Contributor
There was a problem hiding this comment.
I would document the returns part the same way you did in the called function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.