Skip to content

Fix undefined symbol error in RWKV-7 l2wrap CUDA kernel (sync v2 kernels with v1 headers) #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
A190nux wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix undefined symbol error in RWKV-7 l2wrap CUDA kernel (sync v2 kernels with v1 headers) #336

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions RWKV-v7/train_temp/cuda/rwkv7_l2wrap_ce_bf16_v1.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

#include <vector>

std::vector<torch::Tensor> l2wrap_ce_forward_v1_cuda(torch::Tensor logits, torch::Tensor targets, int64_t vocab);
torch::Tensor l2wrap_ce_backward_v1_cuda(
std::vector<torch::Tensor> l2wrap_ce_forward_v2_cuda(torch::Tensor logits, torch::Tensor targets, int64_t vocab);
torch::Tensor l2wrap_ce_backward_v2_cuda(
torch::Tensor grad_loss,
torch::Tensor logits,
torch::Tensor targets,
Expand Down Expand Up @@ -37,7 +37,7 @@ int64_t check_logits_targets(const torch::Tensor& logits, const torch::Tensor& t

std::vector<torch::Tensor> forward(torch::Tensor logits, torch::Tensor targets) {
const int64_t vocab = check_logits_targets(logits, targets);
return l2wrap_ce_forward_v1_cuda(logits, targets, vocab);
return l2wrap_ce_forward_v2_cuda(logits, targets, vocab);
}

torch::Tensor backward(
Expand All @@ -61,7 +61,7 @@ torch::Tensor backward(
TORCH_CHECK(lse.numel() == rows, "lse shape mismatch");
TORCH_CHECK(max_vals.numel() == rows, "max_vals shape mismatch");
TORCH_CHECK(argmax.numel() == rows, "argmax shape mismatch");
return l2wrap_ce_backward_v1_cuda(grad_loss, logits, targets, lse, max_vals, argmax, vocab);
return l2wrap_ce_backward_v2_cuda(grad_loss, logits, targets, lse, max_vals, argmax, vocab);
}

PYBIND11_MODULE(TORCH_EXTENSION_NAME, m) {
Expand Down