-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Add heartbeat notification. #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
stopped using our app and we will indefinitely send them notifications. A new heartbeat endpoint has been added where we send a push to a user every 2 days and if they fail to respond back 10 consecutive times, we stop serving them.
Summary of ChangesHello @niteshbalusu11, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a crucial feature to enhance user engagement and resource management by introducing a heartbeat notification system. The primary goal is to intelligently detect inactive users and automatically stop sending them notifications, thereby optimizing server resources and improving the user experience for active users. This is achieved through periodic heartbeat checks and a mechanism to deregister users who consistently fail to respond. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a heartbeat mechanism to identify and deregister inactive users, which is a valuable addition for resource management. The implementation is solid, with new cron jobs, database tables, and API endpoints. I've included a few suggestions to enhance robustness and maintainability, particularly around error handling in the cron jobs and ensuring complete data cleanup during user deregistration. One critical issue was found that could lead to users being unfairly deregistered, which should be addressed.
feat: Add heartbeat notification. Right now we do not know if a user has stopped using our app and we will indefinitely send them notifications.
A new heartbeat endpoint has been added where we send a push to a user
every 2 days and if they fail to respond back 10 consecutive times, we
stop serving them.