Skip to content

Conversation

niteshbalusu11
Copy link
Member

feat: Add heartbeat notification. Right now we do not know if a user has stopped using our app and we will indefinitely send them notifications.
A new heartbeat endpoint has been added where we send a push to a user
every 2 days and if they fail to respond back 10 consecutive times, we
stop serving them.

stopped using our app and we will indefinitely send them notifications.
A new heartbeat endpoint has been added where we send a push to a user
every 2 days and if they fail to respond back 10 consecutive times, we
stop serving them.
Copy link
Contributor

Summary of Changes

Hello @niteshbalusu11, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a crucial feature to enhance user engagement and resource management by introducing a heartbeat notification system. The primary goal is to intelligently detect inactive users and automatically stop sending them notifications, thereby optimizing server resources and improving the user experience for active users. This is achieved through periodic heartbeat checks and a mechanism to deregister users who consistently fail to respond.

Highlights

  • Heartbeat Notification System: Introduced a new system to send periodic 'heartbeat' push notifications to users to monitor their activity.
  • Inactive User Detection: The system identifies inactive users by tracking responses to heartbeat notifications. If a user fails to respond to 10 consecutive heartbeats, they are marked as inactive.
  • Automated Deregistration: Inactive users will be automatically deregistered, meaning their push tokens and offboarding requests will be removed, preventing unnecessary notification sends.
  • Client-Side Heartbeat Response: The client application now includes logic to receive and respond to heartbeat notifications, acknowledging user activity.
  • New Database Schema and Repository: A new heartbeat_notifications table and HeartbeatRepository have been added to store and manage heartbeat notification states and user activity.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a heartbeat mechanism to identify and deregister inactive users, which is a valuable addition for resource management. The implementation is solid, with new cron jobs, database tables, and API endpoints. I've included a few suggestions to enhance robustness and maintainability, particularly around error handling in the cron jobs and ensuring complete data cleanup during user deregistration. One critical issue was found that could lead to users being unfairly deregistered, which should be addressed.

@niteshbalusu11 niteshbalusu11 merged commit 1de11b4 into master Sep 26, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant