Skip to content

Conversation

niteshbalusu11
Copy link
Member

@niteshbalusu11 niteshbalusu11 commented Oct 6, 2025

  • Setup 1 end to end test with maestro for now.
  • Setup maestro testing in our pipelines for iOS.

Copy link
Contributor

Summary of Changes

Hello @niteshbalusu11, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request establishes the foundational setup for Maestro UI testing within the project. It includes the necessary configuration files and package.json scripts to enable automated end-to-end testing, alongside minor adjustments to build configurations for both Android and iOS, and the specification of the Bun runtime version. The primary goal is to streamline the process of creating and running UI tests for the application.

Highlights

  • Maestro UI Testing Setup: Integrated Maestro for UI testing by adding new flow definition files (example-flow.yml.bak, setup-wallet.yml) and a dedicated maestro:test script to package.json.
  • New Build and Fingerprint Scripts: Introduced several new package.json scripts including build:ios:ci for continuous integration builds, fingerprint:android and fingerprint:ios for generating update fingerprints, and build:debug:android/build:debug:ios for debug builds.
  • Bun Version Specification: Added a .bun-version file to explicitly define the Bun runtime version used in the client directory.
  • Android Version Name Update: Modified the versionName in client/android/app/build.gradle from "1.0.0" to "0.0.1".
  • iOS Static Linking Configuration: Added the ios.forceStaticLinking property to client/ios/Podfile.properties.json to configure static linking for iOS builds.
  • Build Output Ignored: Updated .gitignore to include client/build, preventing build artifacts from being committed to the repository.
Ignored Files
  • Ignored by pattern: .github/workflows/** (6)
    • .github/workflows/noah-build-debug-android.yml.bak
    • .github/workflows/noah-build-release-ios.yml
    • .github/workflows/noah-lookup-cached-debug-build.yml
    • .github/workflows/noah-maestro-test-android.yml.bak
    • .github/workflows/noah-maestro-test-ios.yml
    • .github/workflows/pull-request.yml.bak
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request sets up Maestro for UI testing, including test flows, build scripts, and configuration changes. The changes are a good step towards automated testing. I've found a few areas for improvement:

  • A backup file (.bak) has been included in the commit, which should be removed.
  • There's a typo in one of the Maestro flow files.
  • The new build scripts in package.json for iOS and Android can be improved to correctly and efficiently build the app for testing.
    My detailed comments are below.

@niteshbalusu11 niteshbalusu11 changed the title Setup maestro testing Setup maestro testing locally and CI Oct 7, 2025
@niteshbalusu11 niteshbalusu11 merged commit 3ccf41d into master Oct 7, 2025
4 checks passed
@niteshbalusu11 niteshbalusu11 mentioned this pull request Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant