Skip to content

Conversation

niteshbalusu11
Copy link
Member

No description provided.

Copy link
Contributor

Summary of Changes

Hello @niteshbalusu11, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the development environment setup by transitioning the application's default testing environment to 'regtest' and standardizing package names. It introduces new scripting capabilities to easily manage the Noah server within the development workflow and automates the complete environment setup process, ensuring consistency and ease of use for developers.

Highlights

  • Environment Configuration Update: The appId in client/.maestro/setup-wallet.yml has been updated from signet to regtest, indicating a shift in the default testing environment for Maestro flows.
  • Package Name Standardization: The application's package name and ID have been standardized from com.anonymous.noah to com.noahwallet across various Android configuration files (build.gradle, MainActivity.kt, MainApplication.kt, app.config.ts), and google-services.json files for mainnet, regtest, and signet.
  • Noah Server Integration into Dev Workflow: New commands and functions have been added to scripts/ark-dev.sh to manage the Noah server, including create-noah-config, start-noah-server, and stop-noah-server. A comprehensive setup-everything command has also been introduced to automate the full development environment setup, including the Noah server.
  • Build Script Adjustments: Android build scripts in package.json have been updated to reflect the new app-id values, and the build:ios:ci scheme has been changed from Noah-Signet to Noah-Regtest.
Ignored Files
  • Ignored by pattern: .github/workflows/** (2)
    • .github/workflows/noah-build-release-ios.yml
    • .github/workflows/noah-maestro-test-ios.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces two main changes: a refactoring of the Android application's package name from com.anonymous.noah to com.noahwallet, and the setup of a regtest environment for development and CI. The package name change is applied consistently across multiple configuration and source files. The regtest setup includes a new powerful ark-dev.sh script to manage the development environment, which is a great improvement for developer experience. My review focuses on a critical security issue regarding a hardcoded API key and a suggestion to improve the robustness of the new development script.

niteshbalusu11 and others added 5 commits October 7, 2025 12:45
Modify server-push workflow to build and push Docker images for both
amd64 and arm64 architectures, with a separate stage to create a
multi-arch manifest. Optimize Dockerfile using cargo-chef for improved
build caching.
@niteshbalusu11 niteshbalusu11 merged commit e5c7123 into master Oct 7, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant